allow salt lengths != 8 in PBES1 #12959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperhulk
force-pushed
the
fix-longer-salts
branch
2 times, most recently
from
c30af4b to
463f8d9
Compare
reaperhulk
force-pushed
the
fix-longer-salts
branch
from
463f8d9 to
2200275
Compare
alex
reviewed
May 21, 2025
|
Before we merge, we need to contact bouncy castle to let them know in case this is unintended. |
|
#12976 does this with a rename to make things less confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12958
I am not yet sure that this is the right fix, so please review carefully.